chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java - Issue 2895223003: [Home] Add some accessibility support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

Issue 2895223003: [Home] Add some accessibility support (Closed)

Patch Set: Add content description to toolbar Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheet.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

index 934766087ee965315b4879d9b43419e599f1ba4b..d260410822713e1f28336484fe6326cafbf6bbdb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/BottomSheetContentController.java

@@ -115,6 +115,8 @@ public class BottomSheetContentController extends BottomNavigationView

@Override

public void onSheetContentChanged(BottomSheetContent newContent) {

+ if (mBottomSheet.isSheetOpen()) announceBottomSheetContentSelected();

if (!mShouldOpenSheetOnNextContentChange) return;

mShouldOpenSheetOnNextContentChange = false;

@@ -292,7 +294,20 @@ public class BottomSheetContentController extends BottomNavigationView

mSelectedItemId = navItemId;

getMenu().findItem(mSelectedItemId).setChecked(true);

- mBottomSheet.showContent(getSheetContentForId(mSelectedItemId));

+ BottomSheetContent newContent = getSheetContentForId(mSelectedItemId);

+ mBottomSheet.showContent(newContent);

+ }

+ private void announceBottomSheetContentSelected() {

+ if (mSelectedItemId == R.id.action_home) {

+ announceForAccessibility(getResources().getString(R.string.bottom_sheet_home_tab));

+ } else if (mSelectedItemId == R.id.action_downloads) {

+ announceForAccessibility(getResources().getString(R.string.bottom_sheet_downloads_tab));

+ } else if (mSelectedItemId == R.id.action_bookmarks) {

+ announceForAccessibility(getResources().getString(R.string.bottom_sheet_bookmarks_tab));

+ } else if (mSelectedItemId == R.id.action_history) {

+ announceForAccessibility(getResources().getString(R.string.bottom_sheet_history_tab));

+ }

}

private void updateVisuals(boolean isIncognitoTabModelSelected) {