Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 2895153005: Revert "Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend pa… (Closed)

Created:
3 years, 7 months ago by aam
Modified:
3 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Revert "With this change 'tools/test.py -cdartk vm' will run vm tests with Dart Frontend parser."" This reverts commit e0cdea811a368d6aa53e31741bc027fd48106448. Update status of vm tests, that don't work with DFE yet. BUG=https://github.com/dart-lang/sdk/issues/28264 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/16c0db1022ff3294678479e60e3deee2e96dff05

Patch Set 1 #

Patch Set 2 : Separate debug crashes from release failures #

Patch Set 3 : Update test status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -2 lines) Patch
M runtime/tests/vm/vm.status View 1 2 2 chunks +248 lines, -1 line 0 comments Download
M tools/testing/dart/test_configurations.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
aam
3 years, 7 months ago (2017-05-23 05:19:54 UTC) #3
siva
lgtm
3 years, 7 months ago (2017-05-24 21:46:07 UTC) #4
aam
3 years, 7 months ago (2017-05-25 03:16:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
16c0db1022ff3294678479e60e3deee2e96dff05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698