Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/objects-inl.h

Issue 289503002: ES6 Map/Set iterators/forEach improvements (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: partial code review feedback update Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5662 matching lines...) Expand 10 before | Expand all | Expand 10 after
5673 } \ 5673 } \
5674 template<class Derived, class TableType> \ 5674 template<class Derived, class TableType> \
5675 void OrderedHashTableIterator<Derived, TableType>::set_##name( \ 5675 void OrderedHashTableIterator<Derived, TableType>::set_##name( \
5676 type* value, WriteBarrierMode mode) { \ 5676 type* value, WriteBarrierMode mode) { \
5677 WRITE_FIELD(this, offset, value); \ 5677 WRITE_FIELD(this, offset, value); \
5678 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \ 5678 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \
5679 } 5679 }
5680 5680
5681 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset) 5681 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset)
5682 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Smi, kIndexOffset) 5682 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Smi, kIndexOffset)
5683 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(count, Smi, kCountOffset)
5684 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Smi, kKindOffset) 5683 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Smi, kKindOffset)
5685 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(next_iterator, Object,
5686 kNextIteratorOffset)
5687 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(previous_iterator, Object,
5688 kPreviousIteratorOffset)
5689 5684
5690 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS 5685 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS
5691 5686
5692 5687
5693 ACCESSORS(JSWeakCollection, table, Object, kTableOffset) 5688 ACCESSORS(JSWeakCollection, table, Object, kTableOffset)
5694 ACCESSORS(JSWeakCollection, next, Object, kNextOffset) 5689 ACCESSORS(JSWeakCollection, next, Object, kNextOffset)
5695 5690
5696 5691
5697 Address Foreign::foreign_address() { 5692 Address Foreign::foreign_address() {
5698 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset)); 5693 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset));
(...skipping 1156 matching lines...) Expand 10 before | Expand all | Expand 10 after
6855 #undef READ_SHORT_FIELD 6850 #undef READ_SHORT_FIELD
6856 #undef WRITE_SHORT_FIELD 6851 #undef WRITE_SHORT_FIELD
6857 #undef READ_BYTE_FIELD 6852 #undef READ_BYTE_FIELD
6858 #undef WRITE_BYTE_FIELD 6853 #undef WRITE_BYTE_FIELD
6859 #undef NOBARRIER_READ_BYTE_FIELD 6854 #undef NOBARRIER_READ_BYTE_FIELD
6860 #undef NOBARRIER_WRITE_BYTE_FIELD 6855 #undef NOBARRIER_WRITE_BYTE_FIELD
6861 6856
6862 } } // namespace v8::internal 6857 } } // namespace v8::internal
6863 6858
6864 #endif // V8_OBJECTS_INL_H_ 6859 #endif // V8_OBJECTS_INL_H_
OLDNEW
« src/objects.cc ('K') | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698