Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/objects-inl.h

Issue 289503002: ES6 Map/Set iterators/forEach improvements (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: git rebase to fix merge conflict Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 5665 matching lines...) Expand 10 before | Expand all | Expand 10 after
5676 } \ 5676 } \
5677 template<class Derived, class TableType> \ 5677 template<class Derived, class TableType> \
5678 void OrderedHashTableIterator<Derived, TableType>::set_##name( \ 5678 void OrderedHashTableIterator<Derived, TableType>::set_##name( \
5679 type* value, WriteBarrierMode mode) { \ 5679 type* value, WriteBarrierMode mode) { \
5680 WRITE_FIELD(this, offset, value); \ 5680 WRITE_FIELD(this, offset, value); \
5681 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \ 5681 CONDITIONAL_WRITE_BARRIER(GetHeap(), this, offset, value, mode); \
5682 } 5682 }
5683 5683
5684 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset) 5684 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(table, Object, kTableOffset)
5685 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Smi, kIndexOffset) 5685 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(index, Smi, kIndexOffset)
5686 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(count, Smi, kCountOffset)
5687 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Smi, kKindOffset) 5686 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(kind, Smi, kKindOffset)
5688 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(next_iterator, Object,
5689 kNextIteratorOffset)
5690 ORDERED_HASH_TABLE_ITERATOR_ACCESSORS(previous_iterator, Object,
5691 kPreviousIteratorOffset)
5692 5687
5693 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS 5688 #undef ORDERED_HASH_TABLE_ITERATOR_ACCESSORS
5694 5689
5695 5690
5696 ACCESSORS(JSWeakCollection, table, Object, kTableOffset) 5691 ACCESSORS(JSWeakCollection, table, Object, kTableOffset)
5697 ACCESSORS(JSWeakCollection, next, Object, kNextOffset) 5692 ACCESSORS(JSWeakCollection, next, Object, kNextOffset)
5698 5693
5699 5694
5700 Address Foreign::foreign_address() { 5695 Address Foreign::foreign_address() {
5701 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset)); 5696 return AddressFrom<Address>(READ_INTPTR_FIELD(this, kForeignAddressOffset));
(...skipping 1156 matching lines...) Expand 10 before | Expand all | Expand 10 after
6858 #undef READ_SHORT_FIELD 6853 #undef READ_SHORT_FIELD
6859 #undef WRITE_SHORT_FIELD 6854 #undef WRITE_SHORT_FIELD
6860 #undef READ_BYTE_FIELD 6855 #undef READ_BYTE_FIELD
6861 #undef WRITE_BYTE_FIELD 6856 #undef WRITE_BYTE_FIELD
6862 #undef NOBARRIER_READ_BYTE_FIELD 6857 #undef NOBARRIER_READ_BYTE_FIELD
6863 #undef NOBARRIER_WRITE_BYTE_FIELD 6858 #undef NOBARRIER_WRITE_BYTE_FIELD
6864 6859
6865 } } // namespace v8::internal 6860 } } // namespace v8::internal
6866 6861
6867 #endif // V8_OBJECTS_INL_H_ 6862 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698