Issue 2895010: Handling case where automation server is NULL when creating the active doc wi...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2895010: Handling case where automation server is NULL when creating the active doc wi... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by tommi

Modified:
4 years ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Handling case where automation server is NULL when creating the active doc window. I'm not sure why the server couldn't be created but we shouldn't crash. BUG=48846 TEST=Fixes crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52191

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	chrome_frame/chrome_active_document.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	chrome_frame/chrome_frame_activex_base.h	View		1 chunk	+6 lines, -1 line	0 comments	Download

Trybot results: mac linux win

Total messages: 2 (0 generated)

lgtm