Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6825)

Unified Diff: chrome_frame/chrome_active_document.cc

Issue 2895010: Handling case where automation server is NULL when creating the active doc wi... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/chrome_frame_activex_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/chrome_active_document.cc
===================================================================
--- chrome_frame/chrome_active_document.cc (revision 51968)
+++ chrome_frame/chrome_active_document.cc (working copy)
@@ -519,6 +519,12 @@
SetFocus();
} else {
m_hWnd = Create(parent_window, position_rect, 0, 0, WS_EX_CLIENTEDGE);
+ if (!IsWindow()) {
+ // This might happen if the automation server couldn't be
+ // instantiated. If so, a NOTREACHED() will have already been hit.
+ DLOG(ERROR) << "Failed to create Ax window";
+ return AtlHresultFromLastError();
+ }
}
ScopedComPtr<IWebBrowser2> web_browser2;
« no previous file with comments | « no previous file | chrome_frame/chrome_frame_activex_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698