Issue 2895004: dhcpcd: generalise package mask to allow uprevs within v5.1.4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2895004: dhcpcd: generalise package mask to allow uprevs within v5.1.4 (Closed)

Created:
10 years, 5 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, Mandeep Singh Baines, sosa, anush

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, awong, adlr, anush

Base URL:
ssh://gitrw.chromium.org/chromiumos-overlay

Visibility:
Public.

Description

dhcpcd: generalise package mask to allow uprevs within v5.1.4

Patch Set 1 #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	profiles/targets/chromeos/package.mask	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM assuming msb is ok with this approach. On Thu, Jul 8, 2010 at 3:48 ...

10 years, 5 months ago (2010-07-08 22:54:46 UTC) #2

Mandeep Singh Baines

10 years, 5 months ago (2010-07-08 23:22:57 UTC) #3

LGTM

Chris Sosa (sosa@chromium.org) wrote:
> LGTM assuming msb is ok with this approach.
> 
> On Thu, Jul 8, 2010 at 3:48 PM,  <zbehan@chromium.org> wrote:
> > Reviewers: Mandeep Singh Baines, anush, sosa, kmixter1,
> >
> > Description:
> > dhcpcd: generalise package mask to allow uprevs within v5.1.4
> >
> > Please review this at http://codereview.chromium.org/2895004/show
> >
> > SVN Base: ssh://gitrw.chromium.org/chromiumos-overlay
> >
> > Affected files:
> > ?M profiles/targets/chromeos/package.mask
> >
> >
> > Index: profiles/targets/chromeos/package.mask
> > diff --git a/profiles/targets/chromeos/package.mask
> > b/profiles/targets/chromeos/package.mask
> > index
> >
c81e7fee6a1c4a58099d678c09cb9ae6e32cf41b..0c42d17dc2b6b3633e525750ccc814bb3247b34c
> > 100644
> > --- a/profiles/targets/chromeos/package.mask
> > +++ b/profiles/targets/chromeos/package.mask
> > @@ -66,4 +66,4 @@
> > ?>dev-libs/libgcrypt-1.4.4
> >
> > ?# Masked all upstream ebuilds, unupstreamable work in local copy
> > ->net-misc/dhcpcd-5.1.4
> > +>=net-misc/dhcpcd-5.1.5
> >
> >
> >

Expand Messages | Collapse Messages