Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp

Issue 2894983002: An unknown role is considered a bug, should never occur (Closed)
Patch Set: Remove useless comment Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
index 37699ded8eb6daca5aa78529441b7caa1843913c..37a136369da5de990baaf1f4b514933fb1d10d54 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXObjectImpl.cpp
@@ -1986,9 +1986,13 @@ bool AXObjectImpl::NameFromContents(bool recursive) const {
case kRowRole:
case kRubyRole:
case kRulerRole:
+ result = recursive || (CanReceiveAccessibilityFocus() && !IsEditable());
+ break;
+
case kUnknownRole:
case kNumRoles:
- result = recursive || (CanReceiveAccessibilityFocus() && !IsEditable());
+ LOG(ERROR) << "kUnknownRole for " << GetNode();
+ NOTREACHED();
break;
}
« no previous file with comments | « third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698