Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Unified Diff: content/public/browser/web_contents_delegate.h

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index 232d3a96040b57a6271651cb8f06f4e5d417251c..9176c4bcee6cffbd9f30109e2dd25fd47a9432f4 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -16,6 +16,7 @@
#include "content/common/content_export.h"
#include "content/public/browser/bluetooth_chooser.h"
#include "content/public/browser/invalidate_type.h"
+#include "content/public/browser/web_contents.h"
#include "content/public/common/media_stream_request.h"
#include "content/public/common/window_container_type.mojom.h"
#include "third_party/WebKit/public/platform/WebDisplayMode.h"
@@ -45,7 +46,6 @@ class RenderFrameHost;
class RenderWidgetHost;
class SessionStorageNamespace;
class SiteInstance;
-class WebContents;
class WebContentsImpl;
struct ColorSuggestion;
struct ContextMenuParams;
@@ -331,12 +331,14 @@ class CONTENT_EXPORT WebContentsDelegate {
// Notifies the delegate about the creation of a new WebContents. This
// typically happens when popups are created.
- virtual void WebContentsCreated(WebContents* source_contents,
- int opener_render_process_id,
- int opener_render_frame_id,
- const std::string& frame_name,
- const GURL& target_url,
- WebContents* new_contents) {}
+ virtual void WebContentsCreated(
+ WebContents* source_contents,
+ int opener_render_process_id,
+ int opener_render_frame_id,
+ const std::string& frame_name,
+ const GURL& target_url,
+ WebContents* new_contents,
+ const base::Optional<WebContents::CreateParams>& create_params) {}
// Notification that the tab is hung.
virtual void RendererUnresponsive(
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698