chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc - Issue 2894973002: Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/metrics_web_contents_observer.cc ('k') | chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

diff --git a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

index ba0fbf0d6b9ddaeb76cca2ee656e642e998dc6e6..2efcc4b3c19e18a73343050d3b51373d33cdde1e 100644

--- a/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

+++ b/chrome/browser/page_load_metrics/metrics_web_contents_observer_unittest.cc

@@ -204,7 +204,7 @@ class MetricsWebContentsObserverTest : public ChromeRenderViewHostTestHarness {

// calling AttachObserver() again. Otherwise they will use-after-free the

// observer_.

observer_ = MetricsWebContentsObserver::CreateForWebContents(

- web_contents(), base::WrapUnique(embedder_interface_));

+ web_contents(), base::nullopt, base::WrapUnique(embedder_interface_));

observer_->WasShown();

}