Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index dc0dfd6e4dd8a7e3a9741b2d1d4474cb2288a995..0ba79b03613c3bd7496352e33f941ea05ff2ecb1 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -1047,12 +1047,14 @@ void DevToolsWindow::AddNewContents(WebContents* source,
}
}
-void DevToolsWindow::WebContentsCreated(WebContents* source_contents,
- int opener_render_process_id,
- int opener_render_frame_id,
- const std::string& frame_name,
- const GURL& target_url,
- WebContents* new_contents) {
+void DevToolsWindow::WebContentsCreated(
+ WebContents* source_contents,
+ int opener_render_process_id,
+ int opener_render_frame_id,
+ const std::string& frame_name,
+ const GURL& target_url,
+ WebContents* new_contents,
+ const base::Optional<content::WebContents::CreateParams>& create_params) {
if (target_url.SchemeIs(content::kChromeDevToolsScheme) &&
target_url.path().rfind("toolbox.html") != std::string::npos) {
CHECK(can_dock_);
« no previous file with comments | « chrome/browser/devtools/devtools_window.h ('k') | chrome/browser/page_load_metrics/metrics_web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698