chrome/browser/android/tab_android.cc - Issue 2894973002: Provide WebContents::CreateParams to tab helpers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.cc

Issue 2894973002: Provide WebContents::CreateParams to tab helpers. (Closed)

Patch Set: rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.cc

diff --git a/chrome/browser/android/tab_android.cc b/chrome/browser/android/tab_android.cc

index 8b2dad9eaaf917c3a279ccc1ad3ff0dbd96aaa15..005669d1972a18eecc865d99ba76532548b442e1 100644

--- a/chrome/browser/android/tab_android.cc

+++ b/chrome/browser/android/tab_android.cc

@@ -119,7 +119,7 @@ TabAndroid* TabAndroid::GetNativeTab(JNIEnv* env, const JavaRef<jobject>& obj) {

void TabAndroid::AttachTabHelpers(content::WebContents* web_contents) {

DCHECK(web_contents);

- TabHelpers::AttachTabHelpers(web_contents);

+ TabHelpers::AttachTabHelpers(web_contents, base::nullopt);

}

TabAndroid::TabAndroid(JNIEnv* env, const JavaRef<jobject>& obj)