runtime/vm/flow_graph_type_propagator.cc - Issue 2894953002: Support inlining of calls where type arguments are passed to generic functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 2894953002: Support inlining of calls where type arguments are passed to generic functions. (Closed)

Patch Set: work in progress Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_type_propagator.cc

diff --git a/runtime/vm/flow_graph_type_propagator.cc b/runtime/vm/flow_graph_type_propagator.cc

index fe3f74222035aec52e969c3e02d3af13226a1ca3..775d646b7ba7ffc3008fe80ae944c3c99dc87fdb 100644

--- a/runtime/vm/flow_graph_type_propagator.cc

+++ b/runtime/vm/flow_graph_type_propagator.cc

@@ -980,9 +980,9 @@ CompileType RelationalOpInstr::ComputeType() const {

}

-CompileType CurrentContextInstr::ComputeType() const {

- return CompileType(CompileType::kNonNullable, kContextCid,

- &Object::dynamic_type());

+CompileType SpecialParameterInstr::ComputeType() const {

+ intptr_t cid = kind() == kContext ? kContextCid : kTypeArgumentsCid;

+ return CompileType(CompileType::kNonNullable, cid, &Object::dynamic_type());

}