Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6770)

Unified Diff: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc

Issue 2894943002: Prevent existing card number to be used for new credit cards in the Payment Request (Closed)
Patch Set: Fixed unit tests crash Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
diff --git a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
index 7c883c8069c7c4c350be7a9c1e0570aed7139b86..9b0bae8f462b064f6904f5ac4ee40f64cad9392e 100644
--- a/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
+++ b/chrome/browser/ui/views/payments/credit_card_editor_view_controller_browsertest.cc
@@ -599,6 +599,32 @@ IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,
request->state()->selected_instrument());
}
+IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest,
+ RefuseExistingCardNumber) {
+ autofill::CreditCard card = autofill::test::GetCreditCard();
+ AddCreditCard(card);
+
+ InvokePaymentRequestUI();
+ OpenPaymentMethodScreen();
+ OpenCreditCardEditorScreen();
+
+ SetEditorTextfieldValue(card.number(), autofill::CREDIT_CARD_NUMBER);
+ ValidatingTextfield* textfield = static_cast<ValidatingTextfield*>(
+ dialog_view()->GetViewByID(EditorViewController::GetInputFieldViewId(
+ autofill::CREDIT_CARD_NUMBER)));
+ ASSERT_TRUE(textfield);
+ EXPECT_TRUE(textfield->invalid());
+ EXPECT_EQ(l10n_util::GetStringUTF16(
+ IDS_PAYMENTS_VALIDATION_ALREADY_USED_CREDIT_CARD_NUMBER),
+ GetErrorLabelForType(autofill::CREDIT_CARD_NUMBER));
+
+ // Now fix it.
+ ASSERT_NE(base::ASCIIToUTF16("4111111111111129"), card.number());
+ SetEditorTextfieldValue(base::ASCIIToUTF16("4111111111111129"),
+ autofill::CREDIT_CARD_NUMBER);
+ EXPECT_FALSE(textfield->invalid());
+}
+
IN_PROC_BROWSER_TEST_F(PaymentRequestCreditCardEditorTest, EnteringEmptyData) {
InvokePaymentRequestUI();

Powered by Google App Engine
This is Rietveld 408576698