extensions/renderer/api_bindings_system_unittest.cc - Issue 2894923003: [Extensions Bindings] Include request id in a custom callback response

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_bindings_system_unittest.cc

Issue 2894923003: [Extensions Bindings] Include request id in a custom callback response (Closed)

Patch Set: really fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_bindings_system_unittest.cc

diff --git a/extensions/renderer/api_bindings_system_unittest.cc b/extensions/renderer/api_bindings_system_unittest.cc

index ca35c5b85c3aabd4ec418694acd4aa893ca9666f..de6c84991b96035f299a6bb779c566a2f1ff2557 100644

--- a/extensions/renderer/api_bindings_system_unittest.cc

+++ b/extensions/renderer/api_bindings_system_unittest.cc

@@ -296,7 +296,6 @@ TEST_F(APIBindingsSystemTest, TestInitializationAndCallbacks) {

const char kTestCall[] = "obj.simpleFunc(2)";

CallFunctionOnObject(context, beta_api, kTestCall);

ValidateLastRequest("beta.simpleFunc", "[2]");

- EXPECT_EQ(-1, last_request()->request_id);

reset_last_request();

}