Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1454)

Unified Diff: extensions/renderer/api_request_handler_unittest.cc

Issue 2894923003: [Extensions Bindings] Include request id in a custom callback response (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api_request_handler_unittest.cc
diff --git a/extensions/renderer/api_request_handler_unittest.cc b/extensions/renderer/api_request_handler_unittest.cc
index d29ba5f78d42c8cd9e4066ad22a21473dc29dff5..cccf4d514f7b35304eaae2141246f908a20e5459 100644
--- a/extensions/renderer/api_request_handler_unittest.cc
+++ b/extensions/renderer/api_request_handler_unittest.cc
@@ -6,6 +6,7 @@
#include "base/bind.h"
#include "base/memory/ptr_util.h"
#include "base/optional.h"
+#include "base/strings/stringprintf.h"
#include "base/values.h"
#include "extensions/renderer/api_binding_test.h"
#include "extensions/renderer/api_binding_test_util.h"
@@ -220,7 +221,8 @@ TEST_F(APIRequestHandlerTest, CustomCallbackArguments) {
ASSERT_TRUE(gin::Converter<ArgumentList>::FromV8(isolate(), result, &args));
ASSERT_EQ(5u, args.size());
EXPECT_EQ("\"method\"", V8ToString(args[0], context));
- EXPECT_EQ("{}", V8ToString(args[1], context));
+ EXPECT_EQ(base::StringPrintf("{\"id\":%d}", request_id),
+ V8ToString(args[1], context));
EXPECT_EQ(callback, args[2]);
EXPECT_EQ("\"response\"", V8ToString(args[3], context));
EXPECT_EQ("\"arguments\"", V8ToString(args[4], context));
@@ -261,7 +263,8 @@ TEST_F(APIRequestHandlerTest, CustomCallbackArgumentsWithEmptyCallback) {
ASSERT_TRUE(gin::Converter<ArgumentList>::FromV8(isolate(), result, &args));
ASSERT_EQ(3u, args.size());
EXPECT_EQ("\"method\"", V8ToString(args[0], context));
- EXPECT_EQ("{}", V8ToString(args[1], context));
+ EXPECT_EQ(base::StringPrintf("{\"id\":%d}", request_id),
+ V8ToString(args[1], context));
EXPECT_TRUE(args[2]->IsUndefined());
EXPECT_TRUE(request_handler.GetPendingRequestIdsForTesting().empty());
« extensions/renderer/api_request_handler.cc ('K') | « extensions/renderer/api_request_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698