Fix dataset type conversion bug in uber.js

chrome/browser/resources/uber/uber.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('uber', function() {
   /**
    * Options for how web history should be handled.
    */
   var HISTORY_STATE_OPTION = {
     PUSH: 1,    // Push a new history state.
@@ skipping 279 matching lines @@
   /**
    * Invokes a method on a subpage. If the subpage has not signaled readiness,
    * queue the message for when it does.
    * @param {string} pageId Should match an id of one of the iframe containers.
    * @param {string} method The name of the method to invoke.
    * @param {Object=} opt_params Optional property page of parameters to pass to
    *     the invoked method.
    */
   function invokeMethodOnPage(pageId, method, opt_params) {
     var frame = $(pageId).querySelector('iframe');
-    if (!frame || !frame.dataset.ready) {
+    if (!frame || !frame.hasAttribute('ready')) {
       queuedInvokes[pageId] = (queuedInvokes[pageId] || []);
       queuedInvokes[pageId].push([method, opt_params]);
     } else {
       uber.invokeMethodOnWindow(frame.contentWindow, method, opt_params);
     }
   }
 
   /**
    * Called in response to a page declaring readiness. Calls any deferred method
    * invocations from invokeMethodOnPage.
    * @param {string} origin The origin of the source iframe.
    */
   function pageReady(origin) {
     var frame = getIframeFromOrigin(origin);
     var container = frame.parentNode;
-    frame.dataset.ready = true;
+    frame.setAttribute('ready', '');
     var queue = queuedInvokes[container.id] || [];
     queuedInvokes[container.id] = undefined;
     for (var i = 0; i < queue.length; i++) {
       uber.invokeMethodOnWindow(frame.contentWindow, queue[i][0], queue[i][1]);
     }
   }
 
   /**
    * Selects and navigates a subpage. This is called from uber-frame.
    * @param {string} pageId Should match an id of one of the iframe containers.
@@ skipping 11 matching lines @@
       frame = container.ownerDocument.createElement('iframe');
       frame.name = pageId;
       frame.setAttribute('role', 'presentation');
       container.appendChild(frame);
       frame.src = sourceUrl;
     } else {
       // There's no particularly good way to know what the current URL of the
       // content frame is as we don't have access to its contentWindow's
       // location, so just replace every time until necessary to do otherwise.
       frame.contentWindow.location.replace(sourceUrl);
-      frame.dataset.ready = false;
+      frame.removeAttribute('ready');
     }
 
     // If the last selected container is already showing, ignore the rest.
     var lastSelected = document.querySelector('.iframe-container.selected');
     if (lastSelected === container)
       return;
 
     if (lastSelected) {
       lastSelected.classList.remove('selected');
       // Setting aria-hidden hides the container from assistive technology
@@ skipping 108 matching lines @@
   }
 
   return {
     onLoad: onLoad,
     onPopHistoryState: onPopHistoryState
   };
 });
 
 window.addEventListener('popstate', uber.onPopHistoryState);
 document.addEventListener('DOMContentLoaded', uber.onLoad);