Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894893002: Add ElementCodegenWorldBuilder (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add ElementCodegenWorldBuilder Reusable parts are left in CodegenWorldBuilderImpl and a stub KernelCodegenWorldBuilder is added. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/789fce309f08757c74684b4a4e33a78136a0f331

Patch Set 1 #

Patch Set 2 : Fix #

Total comments: 2

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -186 lines) Patch
M pkg/compiler/lib/src/backend_strategy.dart View 2 chunks +10 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 2 chunks +3 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/elements/entities.dart View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen_listener.dart View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
A pkg/compiler/lib/src/js_backend/element_strategy.dart View 1 chunk +117 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/enqueuer.dart View 3 chunks +0 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/resolution_listener.dart View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/kernel_strategy.dart View 1 2 chunks +22 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 3 chunks +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 4 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/universe/codegen_world_builder.dart View 16 chunks +145 lines, -74 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 2 chunks +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/type_representation_test.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-19 14:35:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2894893002/diff/20001/pkg/compiler/lib/src/js_backend/codegen_listener.dart File pkg/compiler/lib/src/js_backend/codegen_listener.dart (right): https://codereview.chromium.org/2894893002/diff/20001/pkg/compiler/lib/src/js_backend/codegen_listener.dart#newcode111 pkg/compiler/lib/src/js_backend/codegen_listener.dart:111: CallStructure callStructure = new CallStructure( do we factor ...
3 years, 7 months ago (2017-05-19 20:00:12 UTC) #3
Johnni Winther
https://codereview.chromium.org/2894893002/diff/20001/pkg/compiler/lib/src/js_backend/codegen_listener.dart File pkg/compiler/lib/src/js_backend/codegen_listener.dart (right): https://codereview.chromium.org/2894893002/diff/20001/pkg/compiler/lib/src/js_backend/codegen_listener.dart#newcode111 pkg/compiler/lib/src/js_backend/codegen_listener.dart:111: CallStructure callStructure = new CallStructure( On 2017/05/19 20:00:11, Siggi ...
3 years, 7 months ago (2017-05-22 07:55:01 UTC) #4
Johnni Winther
3 years, 7 months ago (2017-05-22 08:06:06 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
789fce309f08757c74684b4a4e33a78136a0f331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698