Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894883002: Remove more libraries directives from server (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -247 lines) Patch
M pkg/analysis_server/lib/plugin/analysis/analysis_domain.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/analyzed_files.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/navigation/navigation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/analysis/occurrences/occurrences.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_logger.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/channel.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/channel/web_socket_channel.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/collections.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/computer/computer_overrides.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/constants.dart View 2 chunks +7 lines, -9 lines 0 comments Download
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_analysis.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_execution.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domain_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/operation/operation_queue.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/plugin/server_plugin.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/completion.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_plugin.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/element_references.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/search_domain.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/search/type_hierarchy.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/driver.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/http_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/server/stdio_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_core.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/completion_performance.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/combinator_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/field_formal_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/imported_reference_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart View 3 chunks +21 lines, -23 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_member_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/library_prefix_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_declaration_visitor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/local_library_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/optype.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/override_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/static_member_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/suggestion_builder.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/type_member_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/uri_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart/variable_name_contributor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/statement/statement_completion.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/flutter_util.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/levenshtein.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/correction/namespace.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/selection_analyzer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/statement_analyzer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/dependencies/library_dependencies.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/dependencies/reachable_source_collector.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_getter_to_method.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/convert_method_to_getter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_local.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_local.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/inline_method.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/move_file.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/refactoring_internal.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_class_member.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_import.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_label.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_library.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_local.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/rename_unit_member.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/element_visitors.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/hierarchy.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/search/search_engine_internal.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/single_context_manager.dart View 2 chunks +8 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/socket_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/source/caching_pub_package_map_provider.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/ast_writer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/element_writer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/memory_use.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/tree_writer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/average.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/documentation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/watch_manager.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/starter.dart View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Only removals of directives and sorting noise.
3 years, 7 months ago (2017-05-19 13:24:40 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-19 15:24:43 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-19 15:42:35 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
a6214b31291ad8a3ad5c0fce51079e64f25bde29 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698