Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: net/nqe/network_qualities_prefs_manager.cc

Issue 2894863002: Rename TaskRunner::RunsTasksOnCurrentThread() in //net (Closed)
Patch Set: for Requirements Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/nqe/network_qualities_prefs_manager.cc
diff --git a/net/nqe/network_qualities_prefs_manager.cc b/net/nqe/network_qualities_prefs_manager.cc
index 82e22c47a4476ce8e18297b78237d454fd043d00..a8a34c1f4ae70aed08657945d11d8635a55a5093 100644
--- a/net/nqe/network_qualities_prefs_manager.cc
+++ b/net/nqe/network_qualities_prefs_manager.cc
@@ -78,7 +78,7 @@ NetworkQualitiesPrefsManager::NetworkQualitiesPrefsManager(
NetworkQualitiesPrefsManager::~NetworkQualitiesPrefsManager() {
if (!network_task_runner_)
return;
- DCHECK(network_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(network_task_runner_->RunsTasksInCurrentSequence());
if (network_quality_estimator_)
network_quality_estimator_->RemoveNetworkQualitiesCacheObserver(this);
}
@@ -99,7 +99,7 @@ void NetworkQualitiesPrefsManager::InitializeOnNetworkThread(
void NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQuality(
const nqe::internal::NetworkID& network_id,
const nqe::internal::CachedNetworkQuality& cached_network_quality) {
- DCHECK(network_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(network_task_runner_->RunsTasksInCurrentSequence());
// Notify |this| on the pref thread.
pref_task_runner_->PostTask(
@@ -110,13 +110,13 @@ void NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQuality(
}
void NetworkQualitiesPrefsManager::ShutdownOnPrefThread() {
Ryan Sleevi 2017/05/22 17:22:14 OnPrefSequence
Yeol Park 2017/05/23 05:26:33 Done.
- DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(pref_task_runner_->RunsTasksInCurrentSequence());
pref_weak_ptr_factory_.InvalidateWeakPtrs();
pref_delegate_.reset();
}
void NetworkQualitiesPrefsManager::ClearPrefs() {
- DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(pref_task_runner_->RunsTasksInCurrentSequence());
prefs_->Clear();
DCHECK_EQ(0u, prefs_->size());
pref_delegate_->SetDictionaryValue(*prefs_);
@@ -126,7 +126,7 @@ void NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQualityOnPrefThread(
const nqe::internal::NetworkID& network_id,
const nqe::internal::CachedNetworkQuality& cached_network_quality) {
// The prefs can only be written on the pref thread.
- DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(pref_task_runner_->RunsTasksInCurrentSequence());
DCHECK_GE(kMaxCacheSize, prefs_->size());
std::string network_id_string = network_id.ToString();
@@ -170,7 +170,7 @@ void NetworkQualitiesPrefsManager::OnChangeInCachedNetworkQualityOnPrefThread(
}
ParsedPrefs NetworkQualitiesPrefsManager::ForceReadPrefsForTesting() const {
- DCHECK(pref_task_runner_->RunsTasksOnCurrentThread());
+ DCHECK(pref_task_runner_->RunsTasksInCurrentSequence());
std::unique_ptr<base::DictionaryValue> value(
pref_delegate_->GetDictionaryValue());
return ConvertDictionaryValueToMap(value.get());

Powered by Google App Engine
This is Rietveld 408576698