Cast: Only ACK decodable frames

media/cast/framer/framer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_FRAMER_FRAMER_H_
 #define MEDIA_CAST_FRAMER_FRAMER_H_
 
 #include <map>
 
 #include "base/basictypes.h"
@@ skipping 22 matching lines @@
   ~Framer();
 
   // Return true when receiving the last packet in a frame, creating a
   // complete frame. If a duplicate packet for an already complete frame is
   // received, the function returns false but sets |duplicate| to true.
   bool InsertPacket(const uint8* payload_data,
                     size_t payload_size,
                     const RtpCastHeader& rtp_header,
                     bool* duplicate);
 
   // Extracts a complete encoded frame - will only return a complete continuous

[imcheng, 2014/05/14 20:11:24]

From implementation it looks like this is not the case? If it went to the
NextVideoFrameAllowingSkippingFrames branch. Is this comment outdated?

[hubbe, 2014/05/14 21:46:16]

Done.

   // frame.
   // Returns false if the frame does not exist or if the frame is not complete
   // within the given time frame.
   bool GetEncodedVideoFrame(transport::EncodedVideoFrame* video_frame,
-                            bool* next_frame);
+                            bool* next_frame,

[imcheng, 2014/05/14 20:11:24]

What does |next_frame| mean?

[hubbe, 2014/05/14 21:46:16]

Done.

+                            bool* have_multiple_complete_frames);
 
   bool GetEncodedAudioFrame(transport::EncodedAudioFrame* audio_frame,
                             bool* next_frame);
 
   void ReleaseFrame(uint32 frame_id);
 
   // Reset framer state to original state and flush all pending buffers.
   void Reset();
   bool TimeToSendNextCastMessage(base::TimeTicks* time_to_send);
   void SendCastMessage();
 
  private:
   const bool decoder_faster_than_max_frame_rate_;
   FrameList frames_;
   FrameIdMap frame_id_map_;
 
   scoped_ptr<CastMessageBuilder> cast_msg_builder_;
 
   DISALLOW_COPY_AND_ASSIGN(Framer);
 };
 
 }  //  namespace cast
 }  //  namespace media
 
 #endif  // MEDIA_CAST_FRAMER_FRAMER_H_