Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894773004: Changes to make isolate reload functionality work with the --dfe option. (Closed)

Created:
3 years, 7 months ago by siva
Modified:
3 years, 7 months ago
Reviewers:
aam, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Changes to make isolate reload functionality work with the --dfe option. R=aam@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/286dd519487f8d3fb6e97044e4768e15b3935027

Patch Set 1 #

Patch Set 2 : Address code review comments. #

Patch Set 3 : Add asserts. #

Patch Set 4 : kj #

Patch Set 5 : Fix regression test errors. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -75 lines) Patch
M runtime/bin/BUILD.gn View 1 2 3 4 4 chunks +8 lines, -0 lines 0 comments Download
M runtime/bin/bin.gypi View 1 2 3 4 4 chunks +10 lines, -2 lines 0 comments Download
M runtime/bin/dartutils.h View 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +0 lines, -33 lines 0 comments Download
A runtime/bin/dfe.h View 1 2 1 chunk +58 lines, -0 lines 0 comments Download
A runtime/bin/dfe.cc View 1 2 1 chunk +93 lines, -0 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 3 chunks +4 lines, -1 line 0 comments Download
M runtime/bin/loader.cc View 1 2 3 4 3 chunks +18 lines, -0 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 10 chunks +28 lines, -31 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
siva
3 years, 7 months ago (2017-05-20 00:52:50 UTC) #2
aam
On 2017/05/20 00:52:50, siva wrote: awesome, LGTM
3 years, 7 months ago (2017-05-22 16:11:40 UTC) #3
rmacnak
lgtm
3 years, 7 months ago (2017-05-22 23:19:36 UTC) #4
siva
3 years, 7 months ago (2017-05-25 22:40:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as
286dd519487f8d3fb6e97044e4768e15b3935027 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698