chrome/browser/ui/ash/launcher/launcher_context_menu.cc - Issue 2894743002: Make launching apps from shelf more intuitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)

Patch Set: Replace root window with display id in app launch params. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/launcher/launcher_context_menu.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc

index e946dd44beed426485b6b68301a98259aa11d0ea..7b9e279c91216227f6fd9df0dd20a428e6f5fd5f 100644

--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc

@@ -109,7 +109,9 @@ bool LauncherContextMenu::IsCommandIdEnabled(int command_id) const {

void LauncherContextMenu::ExecuteCommand(int command_id, int event_flags) {

switch (static_cast<MenuItem>(command_id)) {

case MENU_OPEN_NEW:

- controller_->Launch(item_.id, ui::EF_NONE);

+ controller_->LaunchApp(

+ item_.id, ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE,

+ wm_shelf_->GetWindow()->GetDisplayNearestWindow().id());

break;

case MENU_CLOSE:

if (item_.type == ash::TYPE_DIALOG) {