chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc - Issue 2894743002: Make launching apps from shelf more intuitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)

Patch Set: Replace root window with display id in app launch params. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/ash/app_list/app_list_controller_ash.cc ('k') | chrome/browser/ui/ash/launcher/chrome_launcher_controller.h » ('j') | chrome/browser/ui/browser_finder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

diff --git a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

index f1bf9036b90887e6e41ce79cb3189479deff466e..f454f2c79e50cb9c6f368066dd4691fde64acacd 100644

--- a/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

+++ b/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc

@@ -116,8 +116,8 @@ void AppShortcutLauncherItemController::ItemSelected(

// Launching some items replaces this item controller instance, which

// destroys its ShelfID string pair; making copies avoid crashes.

- ChromeLauncherController::instance()->LaunchApp(ash::ShelfID(shelf_id()),

- source, ui::EF_NONE);

+ ChromeLauncherController::instance()->LaunchApp(

+ ash::ShelfID(shelf_id()), source, ui::EF_NONE, display_id);

std::move(callback).Run(ash::SHELF_ACTION_NEW_WINDOW_CREATED,

base::nullopt);

return;