chrome/browser/ui/extensions/application_launch.cc - Issue 2894743002: Make launching apps from shelf more intuitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)

Patch Set: This patch set has many platform related issue Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/application_launch.cc

diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc

index ff846ea99a9f46b6db66836a3e96af738f7bedb0..bec79eed2bb3836b55ea480a986d1312b8c247eb 100644

--- a/chrome/browser/ui/extensions/application_launch.cc

+++ b/chrome/browser/ui/extensions/application_launch.cc

@@ -228,7 +228,8 @@ WebContents* OpenApplicationTab(const AppLaunchParams& launch_params,

Profile* const profile = launch_params.profile;

WindowOpenDisposition disposition = launch_params.disposition;

- Browser* browser = chrome::FindTabbedBrowser(profile, false);

+ Browser* browser = chrome::FindTabbedBrowserInRootWindow(

+ profile, false, launch_params.root_window);

WebContents* contents = NULL;

if (!browser) {

// No browser for this profile, need to open a new one.