Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2908)

Unified Diff: chrome/browser/ui/ash/launcher/launcher_context_menu.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)
Patch Set: This patch set has many platform related issue Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/ash/launcher/launcher_context_menu.cc
diff --git a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
index e946dd44beed426485b6b68301a98259aa11d0ea..4cb6382fb71f195f9e3b36366cda1bb97f7196c8 100644
--- a/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
+++ b/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
@@ -109,7 +109,10 @@ bool LauncherContextMenu::IsCommandIdEnabled(int command_id) const {
void LauncherContextMenu::ExecuteCommand(int command_id, int event_flags) {
switch (static_cast<MenuItem>(command_id)) {
case MENU_OPEN_NEW:
- controller_->Launch(item_.id, ui::EF_NONE);
+ controller_->LaunchApp(
+ item_.id, ash::LAUNCH_FROM_UNKNOWN, ui::EF_NONE,
+ ash::WmWindow::GetAuraWindow(wm_shelf_->GetWindow())
+ ->GetRootWindow());
break;
case MENU_CLOSE:
if (item_.type == ash::TYPE_DIALOG) {

Powered by Google App Engine
This is Rietveld 408576698