chrome/browser/ui/ash/app_list/app_list_controller_ash.cc - Issue 2894743002: Make launching apps from shelf more intuitive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)

Patch Set: This patch set has many platform related issue Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

diff --git a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

index c944f12f1860fc7b0d712516420ae6a68549daf3..1b2583b05b6adb19ff64d483e156887c0ab81cb0 100644

--- a/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

+++ b/chrome/browser/ui/ash/app_list/app_list_controller_ash.cc

@@ -115,7 +115,7 @@ void AppListControllerDelegateAsh::LaunchApp(

int event_flags) {

ChromeLauncherController::instance()->LaunchApp(

ash::ShelfID(extension->id()), AppListSourceToLaunchSource(source),

- event_flags);

+ event_flags, NULL);

stevenjb 2017/05/22 17:55:28 Use nullptr and add a comment describing what the

DismissView();

}