Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6494)

Unified Diff: chrome/browser/ui/extensions/app_launch_params.cc

Issue 2894743002: Make launching apps from shelf more intuitive (Closed)
Patch Set: Affected by new revision, gclient sync and re-upload. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/app_launch_params.cc
diff --git a/chrome/browser/ui/extensions/app_launch_params.cc b/chrome/browser/ui/extensions/app_launch_params.cc
index f50c86508061e942de81d0587210db93a3665016..1d3d5d8a96065619426ec8dece5c19dbb56bc9a1 100644
--- a/chrome/browser/ui/extensions/app_launch_params.cc
+++ b/chrome/browser/ui/extensions/app_launch_params.cc
@@ -25,14 +25,16 @@ AppLaunchParams::AppLaunchParams(Profile* profile,
extensions::LaunchContainer container,
WindowOpenDisposition disposition,
extensions::AppLaunchSource source,
- bool set_playstore_status)
+ bool set_playstore_status,
+ int64_t display_id)
: profile(profile),
extension_id(extension ? extension->id() : std::string()),
container(container),
disposition(disposition),
command_line(base::CommandLine::NO_PROGRAM),
source(source),
- play_store_status(PlayStoreStatus::PLAY_STORE_STATUS_UNKNOWN) {
+ play_store_status(PlayStoreStatus::PLAY_STORE_STATUS_UNKNOWN),
+ display_id(display_id) {
#if defined(OS_CHROMEOS)
// TODO(b/34478891): Remove this from app launch.
if (set_playstore_status) {
@@ -65,7 +67,8 @@ AppLaunchParams CreateAppLaunchParamsWithEventFlags(
Profile* profile,
const extensions::Extension* extension,
int event_flags,
- extensions::AppLaunchSource source) {
+ extensions::AppLaunchSource source,
+ int64_t display_id) {
WindowOpenDisposition raw_disposition =
ui::DispositionFromEventFlags(event_flags);
@@ -85,5 +88,6 @@ AppLaunchParams CreateAppLaunchParamsWithEventFlags(
extensions::GetLaunchContainer(ExtensionPrefs::Get(profile), extension);
disposition = WindowOpenDisposition::NEW_FOREGROUND_TAB;
}
- return AppLaunchParams(profile, extension, container, disposition, source);
+ return AppLaunchParams(profile, extension, container, disposition, source,
+ false, display_id);
}
« no previous file with comments | « chrome/browser/ui/extensions/app_launch_params.h ('k') | chrome/browser/ui/extensions/application_launch.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698