Make launching apps from shelf more intuitive

chrome/browser/ui/browser_finder.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/browser_finder.h"
 
 #include <stdint.h>
 
 #include "build/build_config.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 14 matching lines @@
 namespace {
 
 
 // Type used to indicate to match anything.
 const int kMatchAny                     = 0;
 
 // See BrowserMatches for details.
 const int kMatchOriginalProfile         = 1 << 0;
 const int kMatchCanSupportWindowFeature = 1 << 1;
 const int kMatchTabbed                  = 1 << 2;
+const int kMatchRootWindow = 1 << 3;

[stevenjb, 2017/05/22 17:55:29]

Align '= 1 << 3' with lines above.

 
 // Returns true if the specified |browser| matches the specified arguments.
 // |match_types| is a bitmask dictating what parameters to match:
 // . If it contains kMatchOriginalProfile then the original profile of the
 //   browser must match |profile->GetOriginalProfile()|. This is used to match
 //   incognito windows.
 // . If it contains kMatchCanSupportWindowFeature
 //   |CanSupportWindowFeature(window_feature)| must return true.
 // . If it contains kMatchTabbed, the browser must be a tabbed browser.
 bool BrowserMatches(Browser* browser,
                     Profile* profile,
                     Browser::WindowFeature window_feature,
-                    uint32_t match_types) {
+                    uint32_t match_types,
+                    const aura::Window* root_window) {
   if ((match_types & kMatchCanSupportWindowFeature) &&
       !browser->CanSupportWindowFeature(window_feature)) {
     return false;
   }
 
 #if defined(OS_CHROMEOS)
   // Get the profile on which the window is currently shown.
   // MultiUserWindowManager might be NULL under test scenario.
   chrome::MultiUserWindowManager* const window_manager =
       chrome::MultiUserWindowManager::GetInstance();
@@ skipping 20 matching lines @@
 #endif
   } else {
     if (browser->profile() != profile)
       return false;
 #if defined(OS_CHROMEOS)
     if (shown_profile && shown_profile != profile)
       return false;
 #endif
   }
 
-  if (match_types & kMatchTabbed)
-    return browser->is_type_tabbed();
+  if ((match_types & kMatchTabbed) && !browser->is_type_tabbed())
+    return false;
+
+  if (match_types & kMatchRootWindow)
+    return browser->window()->GetNativeWindow()->GetRootWindow() == root_window;
 
   return true;
 }
 
 // Returns the first browser in the specified iterator that returns true from
 // |BrowserMatches|, or null if no browsers match the arguments. See
 // |BrowserMatches| for details on the arguments.
 template <class T>
 Browser* FindBrowserMatching(const T& begin,
                              const T& end,
                              Profile* profile,
                              Browser::WindowFeature window_feature,
-                             uint32_t match_types) {
+                             uint32_t match_types,
+                             const aura::Window* root_window) {
   for (T i = begin; i != end; ++i) {
-    if (BrowserMatches(*i, profile, window_feature, match_types))
+    if (BrowserMatches(*i, profile, window_feature, match_types, root_window))
       return *i;
   }
   return NULL;
 }
 
 Browser* FindBrowserWithTabbedOrAnyType(Profile* profile,
                                         bool match_tabbed,
-                                        bool match_original_profiles) {
+                                        bool match_original_profiles,
+                                        bool match_root_window,
+                                        const aura::Window* root_window) {

[stevenjb, 2017/05/22 17:55:29]

|match_root_window| seems redundant, can we just test 'if (root_window)' ?

[weidongg, 2017/05/23 16:37:46]

Done

   BrowserList* browser_list_impl = BrowserList::GetInstance();
   if (!browser_list_impl)
     return NULL;
   uint32_t match_types = kMatchAny;
   if (match_tabbed)
     match_types |= kMatchTabbed;
   if (match_original_profiles)
     match_types |= kMatchOriginalProfile;
-  Browser* browser = FindBrowserMatching(browser_list_impl->begin_last_active(),
-                                         browser_list_impl->end_last_active(),
-                                         profile,
-                                         Browser::FEATURE_NONE,
-                                         match_types);
+  if (match_root_window)
+    match_types |= kMatchRootWindow;
+  Browser* browser =
+      FindBrowserMatching(browser_list_impl->begin_last_active(),
+                          browser_list_impl->end_last_active(), profile,
+                          Browser::FEATURE_NONE, match_types, root_window);
   // Fall back to a forward scan of all Browsers if no active one was found.
-  return browser ? browser : FindBrowserMatching(browser_list_impl->begin(),
-                                                 browser_list_impl->end(),
-                                                 profile,
-                                                 Browser::FEATURE_NONE,
-                                                 match_types);
+  return browser
+             ? browser
+             : FindBrowserMatching(
+                   browser_list_impl->begin(), browser_list_impl->end(),
+                   profile, Browser::FEATURE_NONE, match_types, root_window);
 }
 
 size_t GetBrowserCountImpl(Profile* profile,
-                           uint32_t match_types) {
+                           uint32_t match_types,
+                           const aura::Window* root_window) {
   BrowserList* browser_list_impl = BrowserList::GetInstance();
   size_t count = 0;
   if (browser_list_impl) {
     for (BrowserList::const_iterator i = browser_list_impl->begin();
          i != browser_list_impl->end(); ++i) {
-      if (BrowserMatches(*i, profile, Browser::FEATURE_NONE, match_types))
+      if (BrowserMatches(*i, profile, Browser::FEATURE_NONE, match_types,
+                         root_window))
         count++;
     }
   }
   return count;
 }
 
 }  // namespace
 
 namespace chrome {
 
 Browser* FindTabbedBrowser(Profile* profile,
                            bool match_original_profiles) {
-  return FindBrowserWithTabbedOrAnyType(profile, true, match_original_profiles);
+  return FindBrowserWithTabbedOrAnyType(profile, true, match_original_profiles,
+                                        false, NULL);

[stevenjb, 2017/05/22 17:55:29]

nullptr throughout

+}
+
+Browser* FindTabbedBrowserInRootWindow(Profile* profile,
+                                       bool match_original_profiles,
+                                       const aura::Window* root_window) {
+  return FindBrowserWithTabbedOrAnyType(profile, true, match_original_profiles,
+                                        true, root_window);
 }
 
 Browser* FindAnyBrowser(Profile* profile,
                         bool match_original_profiles) {
-  return FindBrowserWithTabbedOrAnyType(profile,
-                                        false,
-                                        match_original_profiles);
+  return FindBrowserWithTabbedOrAnyType(profile, false, match_original_profiles,
+                                        false, NULL);
 }
 
 Browser* FindBrowserWithProfile(Profile* profile) {
-  return FindBrowserWithTabbedOrAnyType(profile, false, false);
+  return FindBrowserWithTabbedOrAnyType(profile, false, false, false, NULL);
 }
 
 Browser* FindBrowserWithID(SessionID::id_type desired_id) {
   for (auto* browser : *BrowserList::GetInstance()) {
     if (browser->session_id().id() == desired_id)
       return browser;
   }
   return NULL;
 }
 
@@ skipping 14 matching lines @@
       return it.browser();
   }
   return NULL;
 }
 
 Browser* FindLastActiveWithProfile(Profile* profile) {
   BrowserList* list = BrowserList::GetInstance();
   // We are only interested in last active browsers, so we don't fall back to
   // all browsers like FindBrowserWith* do.
   return FindBrowserMatching(list->begin_last_active(), list->end_last_active(),
-                             profile, Browser::FEATURE_NONE, kMatchAny);
+                             profile, Browser::FEATURE_NONE, kMatchAny, NULL);
 }
 
 Browser* FindLastActive() {
   BrowserList* browser_list_impl = BrowserList::GetInstance();
   if (browser_list_impl)
     return browser_list_impl->GetLastActive();
   return NULL;
 }
 
 size_t GetTotalBrowserCount() {
   return BrowserList::GetInstance()->size();
 }
 
 size_t GetBrowserCount(Profile* profile) {
-  return GetBrowserCountImpl(profile, kMatchAny);
+  return GetBrowserCountImpl(profile, kMatchAny, NULL);
 }
 
 size_t GetTabbedBrowserCount(Profile* profile) {
-  return GetBrowserCountImpl(profile, kMatchTabbed);
+  return GetBrowserCountImpl(profile, kMatchTabbed, NULL);
 }
 
 }  // namespace chrome