Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(388)

Issue 289473008: Export WebCore::forgetV8ObjectForNPObject (Closed)

Created:
5 years, 4 months ago by mnaganov (inactive)
Modified:
5 years, 4 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Visibility:
Public.

Description

Export WebCore::forgetV8ObjectForNPObject This is required for de-associating an NPObject from an existing V8 wrapper, so we don't pull any of the wrapper's custom properties into the context of a new page when navigating to it. BUG=372914 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M Source/web/WebBindings.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M public/web/WebBindings.h View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mnaganov (inactive)
Hi Jochen, It looks like a need to export a function for fixing the issue ...
5 years, 4 months ago (2014-05-14 15:37:07 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 4 months ago (2014-05-15 10:40:17 UTC) #2
mnaganov (inactive)
The CQ bit was checked by mnaganov@chromium.org
5 years, 4 months ago (2014-05-15 12:56:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mnaganov@chromium.org/289473008/1
5 years, 4 months ago (2014-05-15 12:57:04 UTC) #4
commit-bot: I haz the power
5 years, 4 months ago (2014-05-15 14:11:22 UTC) #5
Message was sent while issue was closed.
Change committed as 174083

Powered by Google App Engine
This is Rietveld 408576698