Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 289473006: Fix chromium trunk url in DEPS. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev, kjellander_chromium
Visibility:
Public.

Description

Fix chromium trunk url in DEPS. Makes "svn/trunk" part of the variable so that it can be replaced with "chrome/trunk" when using mirrors. BUG=372738 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21300

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M DEPS View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-14 09:28:00 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-14 09:28:27 UTC) #2
Michael Achenbach
6 years, 7 months ago (2014-05-14 09:29:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21300 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698