Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2405)

Unified Diff: chrome/browser/media/router/mojo/media_router_mojo_impl.cc

Issue 2894623002: [Media Router] Add UMA metrics for media route controller creation (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/media/router/mojo/media_router_mojo_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/router/mojo/media_router_mojo_impl.cc
diff --git a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
index d7cbb2a1857a9a1af1d2002ccaa49e7618ff8ba1..454d93f330e782edbbff537f9cd579b9c6ebf2f1 100644
--- a/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
+++ b/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
@@ -1099,9 +1099,9 @@ void MediaRouterMojoImpl::RemoveInvalidRouteControllers(
void MediaRouterMojoImpl::OnMediaControllerCreated(
const MediaRoute::Id& route_id,
bool success) {
- // TODO(takumif): Record success/failure with UMA.
DVLOG_WITH_INSTANCE(1) << "OnMediaControllerCreated: " << route_id
<< (success ? " was successful." : " failed.");
+ MediaRouterMojoMetrics::RecordMediaRouteControllerCreationResult(success);
}
} // namespace media_router
« no previous file with comments | « no previous file | chrome/browser/media/router/mojo/media_router_mojo_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698