ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm - Issue 2894553003: Add |web_usage_enabled| to DeserializeWebStateList()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

Issue 2894553003: Add |web_usage_enabled| to DeserializeWebStateList() (Closed)

Patch Set: Test web_usage_enabled bool Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm ('K') | « ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

diff --git a/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm b/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

index 4604cdf31792d1578a5e8682f1d81b6b3dccb178..c04d43c3bceef2f8be6fb71920b40ac12f446e5c 100644

--- a/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

+++ b/ios/shared/chrome/browser/ui/browser_list/browser_list_session_service_impl.mm

@@ -232,7 +232,10 @@ void WebStateActivatedAt(WebStateList* web_state_list,

WebStateList& web_state_list = browser->web_state_list();

const int old_count = web_state_list.count();

- DeserializeWebStateList(&web_state_list, session_window, create_web_state_);

+ // TODO(crbug.com/724282): Track whether web usage should be enabled for

+ // the deserialized WebStates.

+ DeserializeWebStateList(&web_state_list, session_window, false,

+ create_web_state_);

DCHECK_GT(web_state_list.count(), old_count);

// If there was a single tab open without any navigation, then close it