Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: google_apis/drive/drive_api_url_generator.h

Issue 2894513003: Fetch files shared in Team Drives by specifying allTeamDrives corpora. (Closed)
Patch Set: Eliminate variables of class type with static storage duration. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/drive/drive_api_url_generator.h
diff --git a/google_apis/drive/drive_api_url_generator.h b/google_apis/drive/drive_api_url_generator.h
index 089912744a28fea4d0e3831d2e213d6e995bb00d..94ffa098cf5883069f8e73ff3d32485d11858c5e 100644
--- a/google_apis/drive/drive_api_url_generator.h
+++ b/google_apis/drive/drive_api_url_generator.h
@@ -15,6 +15,12 @@
namespace google_apis {
+enum FilesListCorpora {
+ CORPORA_DEFAULT,
+ CORPORA_TEAM_DRIVE,
+ CORPORA_ALL_TEAM_DRIVES,
+};
+
// This class is used to generate URLs for communicating with drive api
// servers for production, and a local server for testing.
class DriveApiUrlGenerator {
@@ -68,6 +74,8 @@ class DriveApiUrlGenerator {
// Returns a URL to fetch file list.
GURL GetFilesListUrl(int max_results,
const std::string& page_token,
+ FilesListCorpora corpora,
hashimoto 2017/06/02 09:44:46 How about moving FilesListCorpora enum to drive_ap
yamaguchi 2017/06/02 12:04:01 I think it'd be better to have this parameter an e
+ const std::string& team_drive_id,
const std::string& q) const;
// Returns a URL to delete a resource with the given |file_id|.
@@ -131,6 +139,7 @@ class DriveApiUrlGenerator {
GURL GetBatchUploadUrl() const;
private:
+ static const char* GetCorporaString_(FilesListCorpora corpora);
hashimoto 2017/06/02 09:44:46 This should be a free function in an unnamed names
yamaguchi 2017/06/02 12:04:01 Done.
const GURL base_url_;
const GURL base_download_url_;
const GURL base_thumbnail_url_;

Powered by Google App Engine
This is Rietveld 408576698