Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ios/chrome/browser/ui/browser_view_controller.mm

Issue 2894513002: Adding tools menu responsiveness metric. (Closed)
Patch Set: Tweak to metric description summary Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/chrome/browser/ui/toolbar/toolbar_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/browser_view_controller.mm
diff --git a/ios/chrome/browser/ui/browser_view_controller.mm b/ios/chrome/browser/ui/browser_view_controller.mm
index 1271cea016bb063baa8cc2dd4162d3f0fff7faca..ba8d2dcf650f44e1b609551280f8fa5876c2fa0e 100644
--- a/ios/chrome/browser/ui/browser_view_controller.mm
+++ b/ios/chrome/browser/ui/browser_view_controller.mm
@@ -3384,6 +3384,10 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
DCHECK(_browserState);
DCHECK(self.visible || self.dismissingModal);
+ // Record the time this menu was requested; to be stored in the configuration
+ // object.
+ NSDate* showToolsMenuPopupRequestDate = [NSDate date];
+
// Dismiss the omnibox (if open).
[_toolbarController cancelOmniboxEdit];
// Dismiss the soft keyboard (if open).
@@ -3393,6 +3397,8 @@ class BrowserBookmarkModelBridge : public bookmarks::BookmarkModelObserver {
ToolsMenuConfiguration* configuration =
[[ToolsMenuConfiguration alloc] initWithDisplayView:[self view]];
+ configuration.requestStartTime =
+ showToolsMenuPopupRequestDate.timeIntervalSinceReferenceDate;
if ([_model count] == 0)
[configuration setNoOpenedTabs:YES];
« no previous file with comments | « no previous file | ios/chrome/browser/ui/toolbar/toolbar_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698