Adding tools menu responsiveness metric.

ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.mm

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_controller.h"
 
 #include <stdint.h>
 
 #include "base/ios/ios_util.h"
 #import "base/ios/weak_nsobject.h"
 #include "base/logging.h"
 #include "base/mac/objc_property_releaser.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/metrics/field_trial.h"
+#include "base/metrics/histogram_macros.h"
 #include "components/strings/grit/components_strings.h"
 #include "ios/chrome/browser/experimental_flags.h"
 #import "ios/chrome/browser/ui/animation_util.h"
 #import "ios/chrome/browser/ui/commands/UIKit+ChromeExecuteCommand.h"
 #include "ios/chrome/browser/ui/commands/ios_command_ids.h"
 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notification_delegate.h"
 #import "ios/chrome/browser/ui/reading_list/reading_list_menu_notifier.h"
 #import "ios/chrome/browser/ui/tools_menu/reading_list_menu_view_item.h"
 #import "ios/chrome/browser/ui/tools_menu/tools_menu_constants.h"
 #import "ios/chrome/browser/ui/tools_menu/tools_menu_model.h"
 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_item.h"
 #import "ios/chrome/browser/ui/tools_menu/tools_menu_view_tools_cell.h"
 #import "ios/chrome/browser/ui/tools_menu/tools_popup_controller.h"
 #include "ios/chrome/browser/ui/ui_util.h"
 #import "ios/chrome/browser/ui/uikit_ui_util.h"
 #import "ios/chrome/common/material_timing.h"
 #include "ios/chrome/grit/ios_strings.h"
 #include "ios/public/provider/chrome/browser/chrome_browser_provider.h"
 #import "ios/public/provider/chrome/browser/user_feedback/user_feedback_provider.h"
 #import "ios/shared/chrome/browser/ui/tools_menu/tools_menu_configuration.h"
 #import "ios/third_party/material_components_ios/src/components/Ink/src/MaterialInk.h"
 #include "ios/web/public/user_agent.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/base/l10n/l10n_util_mac.h"
-
 using ios::material::TimingFunction;
 
 namespace {
 
 // Time for ink to fade into view.
 static const NSTimeInterval kMDCInkTouchDelayInterval = 0.15;
 
 static const CGFloat kMenuItemHeight = 48;
 
 static NSString* const kToolsItemCellID = @"ToolsItemCellID";
@@ skipping 57 matching lines @@
                                       ReadingListMenuNotificationDelegate> {
   base::mac::ObjCPropertyReleaser _propertyReleaser_ToolsMenuViewController;
   BOOL _waitForInk;
   // Weak pointer to ReadingListMenuNotifier, used to set the starting values
   // for the reading list badge.
   base::WeakNSObject<ReadingListMenuNotifier> _readingListMenuNotifier;
 }
 @property(nonatomic, retain) ToolsMenuCollectionView* menuView;
 @property(nonatomic, retain) MDCInkView* touchFeedbackView;
 @property(nonatomic, assign) ToolbarType toolbarType;
+// Populated by the configuration object in |initializeMenuWithConfiguration:|
+// stores the time this view controller was requested by the user for the
+// reporting of metrics.
+@property(nonatomic, assign) NSTimeInterval requestStartTime;
 
 // Returns the reading list cell.
 - (ReadingListMenuViewCell*)readingListCell;
 @end
 
 @implementation ToolsMenuViewController
 
 @synthesize menuView = _menuView;
 @synthesize isCurrentPageBookmarked = _isCurrentPageBookmarked;
 @synthesize touchFeedbackView = _touchFeedbackView;
 @synthesize isTabLoading = _isTabLoading;
 @synthesize toolbarType = _toolbarType;
 @synthesize menuItems = _menuItems;
 @synthesize delegate = _delegate;
+@synthesize requestStartTime = _requestStartTime;
 
 #pragma mark Public methods
 
 - (CGFloat)optimalHeight:(CGFloat)suggestedHeight {
   NSInteger numberOfItems = [self.menuItems count];
   if (_toolbarType == ToolbarTypeWebiPhone) {
     // Account for the height of the first row, not included in |menuItems|.
     numberOfItems++;
   }
   CGFloat maxItems = suggestedHeight / kMenuItemHeight;
@@ skipping 61 matching lines @@
 
 - (void)setIsTabLoading:(BOOL)isTabLoading {
   _isTabLoading = isTabLoading;
 
   ToolsMenuViewToolsCell* toolsCell = [self toolsCell];
   [[toolsCell stopButton] setHidden:!isTabLoading];
   [[toolsCell reloadButton] setHidden:isTabLoading];
 }
 
 - (void)initializeMenuWithConfiguration:(ToolsMenuConfiguration*)configuration {
+  self.requestStartTime = configuration.requestStartTime;
+
   if (configuration.readingListMenuNotifier) {
     _readingListMenuNotifier.reset(configuration.readingListMenuNotifier);
     [configuration.readingListMenuNotifier setDelegate:self];
   }
 
   if (IsIPadIdiom()) {
     _toolbarType =
         configuration.hasNoOpenedTabs
             ? ToolbarTypeNoTabsiPad
             : (!IsCompactTablet() ? ToolbarTypeWebiPad : ToolbarTypeWebiPhone);
@@ skipping 205 matching lines @@
           subarrayWithRange:NSMakeRange(1, [visibleCells count] - 1)];
     } else {
       toolsCell = nil;
     }
   }
 
   [CATransaction begin];
   [CATransaction
       setAnimationTimingFunction:TimingFunction(ios::material::CurveEaseInOut)];
   [CATransaction setAnimationDuration:ios::material::kDuration5];
+  [CATransaction setCompletionBlock:^{
+    if (self.requestStartTime != 0) {
+      UMA_HISTOGRAM_TIMES(
+          "Toolbar.ShowToolsMenuResponsiveness",
+          base::TimeDelta::FromSecondsD(
+              [NSDate timeIntervalSinceReferenceDate] - self.requestStartTime));
+      // Reset the start time to ensure that whatever happens, we only record
+      // this once.
+      self.requestStartTime = 0;
+    }
+
+  }];
   AnimateInViews([toolsCell allButtons], 10, 0);
   AnimateInViews(visibleCells, 0, -10);
   [CATransaction commit];
 
   [[self readingListCell]
       updateBadgeCount:_readingListMenuNotifier.get().readingListUnreadCount
               animated:YES];
   [[self readingListCell]
       updateSeenState:_readingListMenuNotifier.get().readingListUnseenItemsExist
              animated:YES];
@@ skipping 162 matching lines @@
 
 - (void)unreadCountChanged:(NSInteger)unreadCount {
   [[self readingListCell] updateBadgeCount:unreadCount animated:YES];
 }
 
 - (void)unseenStateChanged:(BOOL)unseenItemsExist {
   [[self readingListCell] updateSeenState:unseenItemsExist animated:YES];
 }
 
 @end