Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2894483004: DevTools: install resizer on horizontal headers in Sources. (Closed)
Patch Set: same Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All Rights Reserved. 2 * Copyright (C) 2008 Apple Inc. All Rights Reserved.
3 * Copyright (C) 2011 Google Inc. All rights reserved. 3 * Copyright (C) 2011 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1027 matching lines...) Expand 10 before | Expand all | Expand 10 after
1038 if (this._threadsSidebarPane) 1038 if (this._threadsSidebarPane)
1039 this._sidebarPaneStack.showView(this._threadsSidebarPane); 1039 this._sidebarPaneStack.showView(this._threadsSidebarPane);
1040 1040
1041 if (!vertically) 1041 if (!vertically)
1042 this._sidebarPaneStack.appendView(this._watchSidebarPane); 1042 this._sidebarPaneStack.appendView(this._watchSidebarPane);
1043 1043
1044 this._sidebarPaneStack.showView(this._callstackPane); 1044 this._sidebarPaneStack.showView(this._callstackPane);
1045 var jsBreakpoints = /** @type {!UI.View} */ (UI.viewManager.view('sources.js Breakpoints')); 1045 var jsBreakpoints = /** @type {!UI.View} */ (UI.viewManager.view('sources.js Breakpoints'));
1046 var scopeChainView = /** @type {!UI.View} */ (UI.viewManager.view('sources.s copeChain')); 1046 var scopeChainView = /** @type {!UI.View} */ (UI.viewManager.view('sources.s copeChain'));
1047 1047
1048 if (this._tabbedLocationHeader) {
1049 this._splitWidget.uninstallResizer(this._tabbedLocationHeader);
1050 this._tabbedLocationHeader = null;
1051 }
1052
1048 if (!vertically) { 1053 if (!vertically) {
1049 // Populate the rest of the stack. 1054 // Populate the rest of the stack.
1050 this._sidebarPaneStack.showView(scopeChainView); 1055 this._sidebarPaneStack.showView(scopeChainView);
1051 this._sidebarPaneStack.showView(jsBreakpoints); 1056 this._sidebarPaneStack.showView(jsBreakpoints);
1052 this._extensionSidebarPanesContainer = this._sidebarPaneStack; 1057 this._extensionSidebarPanesContainer = this._sidebarPaneStack;
1053 this.sidebarPaneView = vbox; 1058 this.sidebarPaneView = vbox;
1059 this._splitWidget.uninstallResizer(this._debugToolbar.element);
1054 } else { 1060 } else {
1055 var splitWidget = new UI.SplitWidget(true, true, 'sourcesPanelDebuggerSide barSplitViewState', 0.5); 1061 var splitWidget = new UI.SplitWidget(true, true, 'sourcesPanelDebuggerSide barSplitViewState', 0.5);
1056 splitWidget.setMainWidget(vbox); 1062 splitWidget.setMainWidget(vbox);
1057 1063
1058 // Populate the left stack. 1064 // Populate the left stack.
1059 this._sidebarPaneStack.showView(jsBreakpoints); 1065 this._sidebarPaneStack.showView(jsBreakpoints);
1060 1066
1061 var tabbedLocation = UI.viewManager.createTabbedLocation(this._revealDebug gerSidebar.bind(this)); 1067 var tabbedLocation = UI.viewManager.createTabbedLocation(this._revealDebug gerSidebar.bind(this));
1062 splitWidget.setSidebarWidget(tabbedLocation.tabbedPane()); 1068 splitWidget.setSidebarWidget(tabbedLocation.tabbedPane());
1069 this._tabbedLocationHeader = tabbedLocation.tabbedPane().headerElement();
1070 this._splitWidget.installResizer(this._tabbedLocationHeader);
1071 this._splitWidget.installResizer(this._debugToolbar.element);
alph 2017/05/23 21:23:07 Is it ok to call this multiple times for _debugToo
1063 tabbedLocation.appendView(scopeChainView); 1072 tabbedLocation.appendView(scopeChainView);
1064 tabbedLocation.appendView(this._watchSidebarPane); 1073 tabbedLocation.appendView(this._watchSidebarPane);
1065 this._extensionSidebarPanesContainer = tabbedLocation; 1074 this._extensionSidebarPanesContainer = tabbedLocation;
1066 this.sidebarPaneView = splitWidget; 1075 this.sidebarPaneView = splitWidget;
1067 } 1076 }
1068 1077
1069 this._sidebarPaneStack.appendApplicableItems('sources-sidebar'); 1078 this._sidebarPaneStack.appendApplicableItems('sources-sidebar');
1070 var extensionSidebarPanes = Extensions.extensionServer.sidebarPanes(); 1079 var extensionSidebarPanes = Extensions.extensionServer.sidebarPanes();
1071 for (var i = 0; i < extensionSidebarPanes.length; ++i) 1080 for (var i = 0; i < extensionSidebarPanes.length; ++i)
1072 this._addExtensionSidebarPane(extensionSidebarPanes[i]); 1081 this._addExtensionSidebarPane(extensionSidebarPanes[i]);
(...skipping 224 matching lines...) Expand 10 before | Expand all | Expand 10 after
1297 */ 1306 */
1298 willHide() { 1307 willHide() {
1299 UI.inspectorView.setDrawerMinimized(false); 1308 UI.inspectorView.setDrawerMinimized(false);
1300 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance())); 1309 setImmediate(() => Sources.SourcesPanel.updateResizerAndSidebarButtons(Sourc es.SourcesPanel.instance()));
1301 } 1310 }
1302 1311
1303 _showViewInWrapper() { 1312 _showViewInWrapper() {
1304 this._view.show(this.element); 1313 this._view.show(this.element);
1305 } 1314 }
1306 }; 1315 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698