Migrate from ScopedComPtr::CreateInstance() to CoCreateInstance in chrome/...

chrome/installer/util/shell_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines functions that integrate Chrome in Windows shell. These
 // functions can be used by Chrome as well as Chrome installer. All of the
 // work is done by the local functions defined in anonymous namespace in
 // this class.
 
 #include "chrome/installer/util/shell_util.h"
 
 #include <windows.h>
+#include <objbase.h>
 #include <shlobj.h>
 #include <shobjidl.h>
 
 #include <algorithm>
 #include <iterator>
 #include <limits>
 #include <memory>
 #include <string>
 #include <utility>
 
@@ skipping 728 matching lines @@
 // focused. This only works for Windows 8 and Windows 10. The appModelId
 // looks arbitrary but it is the same in Win8 and Win10. There is no easy way to
 // retrieve the appModelId from the registry.
 bool LaunchDefaultAppsSettingsModernDialog(const wchar_t* protocol) {
   DCHECK(protocol);
   static const wchar_t kControlPanelAppModelId[] =
       L"windows.immersivecontrolpanel_cw5n1h2txyewy"
       L"!microsoft.windows.immersivecontrolpanel";
 
   base::win::ScopedComPtr<IApplicationActivationManager> activator;
-  HRESULT hr = activator.CreateInstance(CLSID_ApplicationActivationManager);
+  HRESULT hr = ::CoCreateInstance(CLSID_ApplicationActivationManager, nullptr,
+                                  CLSCTX_ALL, IID_PPV_ARGS(&activator));
   if (SUCCEEDED(hr)) {
     DWORD pid = 0;
     CoAllowSetForegroundWindow(activator.Get(), nullptr);
     hr = activator->ActivateApplication(kControlPanelAppModelId,
                                         L"page=SettingsPageAppsDefaults",
                                         AO_NONE, &pid);
     if (SUCCEEDED(hr)) {
       hr = activator->ActivateApplication(
           kControlPanelAppModelId,
           base::StringPrintf(L"page=SettingsPageAppsDefaults&target=%ls",
@@ skipping 269 matching lines @@
 // (Windows 8); see ProbeProtocolHandlers.  This mechanism is not suitable for
 // use on previous versions of Windows despite the presence of
 // QueryCurrentDefault on them since versions of Windows prior to Windows 8
 // did not perform validation on the ProgID registered as the current default.
 // As a result, stale ProgIDs could be returned, leading to false positives.
 ShellUtil::DefaultState ProbeCurrentDefaultHandlers(
     const base::FilePath& chrome_exe,
     const wchar_t* const* protocols,
     size_t num_protocols) {
   base::win::ScopedComPtr<IApplicationAssociationRegistration> registration;
-  HRESULT hr = registration.CreateInstance(
-      CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC);
+  HRESULT hr =
+      ::CoCreateInstance(CLSID_ApplicationAssociationRegistration, NULL,
+                         CLSCTX_INPROC, IID_PPV_ARGS(&registration));
   if (FAILED(hr))
     return ShellUtil::UNKNOWN_DEFAULT;
 
   base::string16 prog_id(install_static::GetProgIdPrefix());
   prog_id += ShellUtil::GetCurrentInstallationSuffix(chrome_exe);
 
   for (size_t i = 0; i < num_protocols; ++i) {
     base::win::ScopedCoMem<wchar_t> current_app;
     hr = registration->QueryCurrentDefault(protocols[i], AT_URLPROTOCOL,
                                            AL_EFFECTIVE, &current_app);
     if (FAILED(hr) || prog_id.compare(current_app) != 0)
       return ShellUtil::NOT_DEFAULT;
   }
 
   return ShellUtil::IS_DEFAULT;
 }
 
 // Probe using IApplicationAssociationRegistration::QueryAppIsDefault (Vista and
 // Windows 7); see ProbeProtocolHandlers.
 ShellUtil::DefaultState ProbeAppIsDefaultHandlers(
     const base::FilePath& chrome_exe,
     const wchar_t* const* protocols,
     size_t num_protocols) {
   base::win::ScopedComPtr<IApplicationAssociationRegistration> registration;
-  HRESULT hr = registration.CreateInstance(
-      CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC);
+  HRESULT hr =
+      ::CoCreateInstance(CLSID_ApplicationAssociationRegistration, NULL,
+                         CLSCTX_INPROC, IID_PPV_ARGS(&registration));
   if (FAILED(hr))
     return ShellUtil::UNKNOWN_DEFAULT;
 
   base::string16 app_name(GetApplicationName(chrome_exe));
 
   BOOL result;
   for (size_t i = 0; i < num_protocols; ++i) {
     result = TRUE;
     hr = registration->QueryAppIsDefault(protocols[i], AT_URLPROTOCOL,
         AL_EFFECTIVE, app_name.c_str(), &result);
@@ skipping 781 matching lines @@
   bool ret = true;
   // First use the new "recommended" way on Vista to make Chrome default
   // browser.
   base::string16 app_name = GetApplicationName(chrome_exe);
 
   if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
     // On Windows Vista and Win7 we still can set ourselves via the
     // the IApplicationAssociationRegistration interface.
     VLOG(1) << "Registering Chrome as default browser on Vista.";
     base::win::ScopedComPtr<IApplicationAssociationRegistration> pAAR;
-    HRESULT hr = pAAR.CreateInstance(CLSID_ApplicationAssociationRegistration,
-        NULL, CLSCTX_INPROC);
+    HRESULT hr = ::CoCreateInstance(CLSID_ApplicationAssociationRegistration,
+                                    NULL, CLSCTX_INPROC, IID_PPV_ARGS(&pAAR));
     if (SUCCEEDED(hr)) {
       for (int i = 0; kBrowserProtocolAssociations[i] != NULL; i++) {
         hr = pAAR->SetAppAsDefault(app_name.c_str(),
             kBrowserProtocolAssociations[i], AT_URLPROTOCOL);
         if (!SUCCEEDED(hr)) {
           ret = false;
           LOG(ERROR) << "Failed to register as default for protocol "
                      << kBrowserProtocolAssociations[i]
                      << " (" << hr << ")";
         }
@@ skipping 85 matching lines @@
   if (!CanMakeChromeDefaultUnattended())
     return false;
 
   bool ret = true;
   // First use the new "recommended" way on Vista to make Chrome default
   // protocol handler.
   if (base::win::GetVersion() >= base::win::VERSION_VISTA) {
     VLOG(1) << "Registering Chrome as default handler for " << protocol
             << " on Vista.";
     base::win::ScopedComPtr<IApplicationAssociationRegistration> pAAR;
-    HRESULT hr = pAAR.CreateInstance(CLSID_ApplicationAssociationRegistration,
-      NULL, CLSCTX_INPROC);
+    HRESULT hr = ::CoCreateInstance(CLSID_ApplicationAssociationRegistration,
+                                    NULL, CLSCTX_INPROC, IID_PPV_ARGS(&pAAR));
     if (SUCCEEDED(hr)) {
       base::string16 app_name = GetApplicationName(chrome_exe);
       hr = pAAR->SetAppAsDefault(app_name.c_str(), protocol.c_str(),
                                  AT_URLPROTOCOL);
     }
     if (!SUCCEEDED(hr)) {
       ret = false;
       LOG(ERROR) << "Could not make Chrome default protocol client (Vista):"
                  << " HRESULT=" << hr << ".";
     }
@@ skipping 345 matching lines @@
   for (const auto& entry : entries)
     entry->AddToWorkItemList(root, items.get());
 
   // Apply all the registry changes and if there is a problem, rollback
   if (!items->Do()) {
     items->Rollback();
     return false;
   }
   return true;
 }