Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2894453002: Remove the closures used by TypeInferrerImpl.inferInvocation. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the closures used by TypeInferrerImpl.inferInvocation. It's cleaner to just pass in the Arguments object directly. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f47347d96747d0f89fe71581a3e8618944a7fe4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -55 lines) Patch
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 5 chunks +6 lines, -42 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 5 chunks +18 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-17 20:19:49 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 20:47:44 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-17 21:08:44 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f47347d96747d0f89fe71581a3e8618944a7fe4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698