chrome/browser/ui/app_list/arc/arc_app_list_prefs.h - Issue 2894443002: arc: Set custom icon in shelf for ARC apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

Issue 2894443002: arc: Set custom icon in shelf for ARC apps. (Closed)

Patch Set: cleanup Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

index a7eed495ef1b4d93420270fdb7ce996a0c37d057..a80722061fb37042fd229863910a38329ad9caac 100644

--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

@@ -129,6 +129,11 @@ class ArcAppListPrefs

virtual void OnTaskDestroyed(int32_t task_id) {}

// Notifies that task has been activated and moved to the front.

virtual void OnTaskSetActive(int32_t task_id) {}

+ // Notifies that task description has been updated.

+ virtual void OnTaskSetDescription(

msw 2017/05/18 18:26:47 nit: consider OnTaskDescriptionChanged, OnTaskDesc

khmel 2017/05/18 20:27:50 Done.

+ int32_t task_id,

+ const std::string& label,

+ const std::vector<uint8_t>& icon_png_data) {}

virtual void OnNotificationsEnabledChanged(

const std::string& package_name, bool enabled) {}

@@ -288,15 +293,18 @@ class ArcAppListPrefs

const base::Optional<std::string>& intent) override;

void OnTaskDestroyed(int32_t task_id) override;

void OnTaskSetActive(int32_t task_id) override;

+ void OnTaskOrientationLockRequested(

+ int32_t task_id,

+ const arc::mojom::OrientationLock orientation_lock) override;

+ void OnTaskSetDescription(int32_t task_id,

msw 2017/05/18 18:26:47 nit: order to match interface decl.

khmel 2017/05/18 20:27:50 Done.

+ const std::string& label,

+ const std::vector<uint8_t>& icon_png_data) override;

void OnNotificationsEnabledChanged(const std::string& package_name,

bool enabled) override;

void OnPackageAdded(arc::mojom::ArcPackageInfoPtr package_info) override;

void OnPackageModified(arc::mojom::ArcPackageInfoPtr package_info) override;

void OnPackageListRefreshed(

std::vector<arc::mojom::ArcPackageInfoPtr> packages) override;

- void OnTaskOrientationLockRequested(

- int32_t task_id,

- const arc::mojom::OrientationLock orientation_lock) override;

void OnInstallationStarted(

const base::Optional<std::string>& package_name) override;

void OnInstallationFinished(

« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('j') | chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc » ('J')