Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 289443002: Files.app+MTP: Simply show the device model name as a label of the volume. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Files.app+MTP: Simply show the device model name as a label of the volume. Previously it has shown vendor-name + volume-name + device-id where the last part does not mean anything for the end users. BUG=370692 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270041

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M chrome/browser/chromeos/file_manager/volume_manager.cc View 4 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinaba
PTAL. This CL depends on https://codereview.chromium.org/287613002/ to function correctly,
6 years, 7 months ago (2014-05-13 06:23:07 UTC) #1
hirono
lgtm!
6 years, 7 months ago (2014-05-13 06:34:16 UTC) #2
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-13 06:39:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/289443002/1
6 years, 7 months ago (2014-05-13 06:39:28 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 07:15:16 UTC) #5
Message was sent while issue was closed.
Change committed as 270041

Powered by Google App Engine
This is Rietveld 408576698