Issue 2894353002: [windows] Don't set/restore the code page if it's already been set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2894353002: [windows] Don't set/restore the code page if it's already been set (Closed)

Created:
3 years, 7 months ago by zra

Modified:
3 years, 7 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

[windows] Don't set/restore the code page if it's already been set Fixes some messy ninja output during the build. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/299c5f15fd4024fb50d074eeff5766dbaf195537

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	runtime/bin/platform_win.cc	View		1 chunk	+10 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

zra

3 years, 7 months ago (2017-05-22 22:02:31 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
299c5f15fd4024fb50d074eeff5766dbaf195537 (presubmit successful).