chrome/browser/favicon/favicon_handler.h - Issue 28943004: Download and store large favicon for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 28943004: Download and store large favicon for Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable the unittest that is not suitable for Android in Android platform Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.h

diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h

index 4feed38269e27eb9e2a65e63be5aed1b162d0564..91e8e8fc7e74d979dab7e0d5619d90f87db245b9 100644

--- a/chrome/browser/favicon/favicon_handler.h

+++ b/chrome/browser/favicon/favicon_handler.h

@@ -245,7 +245,11 @@ class FaviconHandler {

// Returns the preferred_icon_size according icon_types_, 0 means no

// preference.

int preferred_icon_size() {

+#if defined(OS_ANDROID)

+ return 0;

+#else

return icon_types_ == chrome::FAVICON ? gfx::kFaviconSize : 0;

+#endif

}

// Used for FaviconService requests.

« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »