Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: src/interpreter/bytecodes.h

Issue 2894293003: Save/restore only live registers in the generator suspend/resume. (Closed)
Patch Set: Fix comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index a6c6d0be34761e9153789e2fb672ff4b322e66cd..ebe5f43443bb4c4ec29133e6699f51d6d01fdbc9 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -316,8 +316,10 @@ namespace interpreter {
\
/* Generators */ \
V(SuspendGenerator, AccumulatorUse::kRead, OperandType::kReg, \
- OperandType::kFlag8) \
+ OperandType::kRegList, OperandType::kRegCount, OperandType::kFlag8) \
V(ResumeGenerator, AccumulatorUse::kWrite, OperandType::kReg) \
rmcilroy 2017/06/01 10:44:44 nit - move ResumeGenerator first
Jarin 2017/06/01 12:48:22 Done.
+ V(RestoreGeneratorRegisters, AccumulatorUse::kWrite, OperandType::kReg, \
+ OperandType::kRegOutList, OperandType::kRegCount) \
\
/* Debugger */ \
V(Debugger, AccumulatorUse::kNone) \
@@ -821,6 +823,7 @@ class V8_EXPORT_PRIVATE Bytecodes final {
case OperandType::kRegOutTriple:
return 3;
case OperandType::kRegList:
+ case OperandType::kRegOutList:
UNREACHABLE();
default:
return 0;

Powered by Google App Engine
This is Rietveld 408576698