Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2548)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/verifier.dart

Issue 2894283002: Reapply CL: first step for modular support in fasta (Closed)
Patch Set: new changes since first CL Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/verifier.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/verifier.dart b/pkg/front_end/lib/src/fasta/kernel/verifier.dart
index 91b691a8925c7732cdb76844cdb216afcbfa0de5..691b46351967123ad5bc2698c397b64464b8f539 100644
--- a/pkg/front_end/lib/src/fasta/kernel/verifier.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/verifier.dart
@@ -47,7 +47,9 @@ class FastaVerifyingVisitor extends VerifyingVisitor
problem(TreeNode node, String details, {TreeNode context}) {
context ??= this.context;
VerificationError error = new VerificationError(context, node, details);
- printUnexpected(Uri.parse(fileUri), node?.fileOffset ?? -1, "$error");
+ var uri = fileUri != null ? Uri.parse(fileUri) : null;
ahe 2017/05/22 11:49:04 Why is fileUri null?
Siggi Cherem (dart-lang) 2017/05/22 23:15:48 I ran into this when hitting verification errors f
ahe 2017/05/24 15:45:47 My preference would be to revert this so we can fi
+ var offset = (uri != null && node != null) ? node.fileOffset : -1;
+ printUnexpected(uri, offset, "$error");
errors.add(error);
}

Powered by Google App Engine
This is Rietveld 408576698