Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2894273002: Revert "First step for modular output in fasta." (Closed)

Created:
3 years, 7 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "First step for modular output in fasta." This reverts commit d9e9382373598a953ac184e87454dff78e611111. There were bot failures on incremental_kernel_generator test and in incremental_resolved_ast_test, I'm not sure yet why tests passed locally though. BUG= Committed: https://github.com/dart-lang/sdk/commit/54dcc29835bbbf6ed7745b2e7d2e1c1f47bfc30b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -1263 lines) Patch
M pkg/compiler/lib/src/kernel/fasta_support.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/front_end/lib/compiler_options.dart View 2 chunks +24 lines, -0 lines 0 comments Download
M pkg/front_end/lib/kernel_generator.dart View 5 chunks +15 lines, -74 lines 0 comments Download
M pkg/front_end/lib/src/base/processed_options.dart View 5 chunks +39 lines, -69 lines 0 comments Download
D pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 1 chunk +0 lines, -406 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 8 chunks +12 lines, -50 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 1 chunk +1 line, -3 lines 0 comments Download
D pkg/front_end/test/fasta/shaker.status View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/test/fasta/shaker_test.dart View 1 chunk +0 lines, -241 lines 0 comments Download
M pkg/front_end/test/fasta/testing.json View 4 chunks +4 lines, -22 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 4 chunks +8 lines, -12 lines 0 comments Download
M pkg/front_end/test/src/base/processed_options_test.dart View 4 chunks +39 lines, -20 lines 0 comments Download
M pkg/front_end/test/subpackage_relationships_test.dart View 1 chunk +3 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/shaker/classes_in_signatures.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/classes_in_signatures.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/empty_program.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/empty_program.dart.shaker View 1 chunk +0 lines, -72 lines 0 comments Download
D pkg/front_end/testcases/shaker/implicit_constructors.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/implicit_constructors.dart.shaker View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_bounds.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_bounds.dart.shaker View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_field_type.dart View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/shaker/include_field_type.dart.shaker View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/shaker/lib/lib.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots0.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots0.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots1.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots1.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots2.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots2.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots3.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots3.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots4.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots4.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots5.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots5.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots6.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots6.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots7.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/shaker/roots7.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/toplevel_reference.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/toplevel_reference.dart.shaker View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/shaker/transitive_mixins.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/transitive_mixins.dart.shaker View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/transitive_superclass.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/transitive_superclass.dart.shaker View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/shaker/typedefs_in_types.dart View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/shaker/typedefs_in_types.dart.shaker View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Siggi Cherem (dart-lang)
TBR
3 years, 7 months ago (2017-05-19 22:02:29 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 (id:1) manually as 54dcc29835bbbf6ed7745b2e7d2e1c1f47bfc30b (presubmit successful).
3 years, 7 months ago (2017-05-19 22:02:54 UTC) #4
scheglov
3 years, 7 months ago (2017-05-19 22:03:36 UTC) #5
Message was sent while issue was closed. 
LGTM

FWIW, I had only one failure locally - in incremental_resolved_ast_test.

Powered by Google App Engine
This is Rietveld 408576698