Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 289423004: Turn on ENABLE_NEW_GAMEPAD_API flag so that the new gamepad code is used (Closed)

Created:
5 years, 4 months ago by Inactive
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Turn on ENABLE_NEW_GAMEPAD_API flag so that the new gamepad code is used Turn on ENABLE_NEW_GAMEPAD_API flag so that the new gamepad code is used. Also remove the old code on Chromium side. The ENABLE_NEW_GAMEPAD_API is only needed until the Blink side #ifdefs are removed. BUG=344556 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272723

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add bug number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M build/common.gypi View 1 2 chunks +8 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_gamepad_shared.h View 3 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Inactive
5 years, 4 months ago (2014-05-23 20:55:35 UTC) #1
dmichael (off chromium)
lgtm https://codereview.chromium.org/289423004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/289423004/diff/1/build/common.gypi#newcode2280 build/common.gypi:2280: # away once the chrome and blink interfaces ...
5 years, 4 months ago (2014-05-23 21:02:54 UTC) #2
Inactive
https://codereview.chromium.org/289423004/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/289423004/diff/1/build/common.gypi#newcode2280 build/common.gypi:2280: # away once the chrome and blink interfaces are ...
5 years, 4 months ago (2014-05-23 21:14:39 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
5 years, 4 months ago (2014-05-23 21:15:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/289423004/20001
5 years, 4 months ago (2014-05-23 21:16:05 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
5 years, 4 months ago (2014-05-24 01:40:18 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
5 years, 4 months ago (2014-05-24 03:14:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/19492)
5 years, 4 months ago (2014-05-24 03:14:51 UTC) #8
Inactive
The CQ bit was checked by ch.dumez@samsung.com
5 years, 4 months ago (2014-05-24 03:15:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/289423004/20001
5 years, 4 months ago (2014-05-24 03:16:25 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2014-05-24 12:47:02 UTC) #11
Message was sent while issue was closed.
Change committed as 272723

Powered by Google App Engine
This is Rietveld 408576698