Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp - Issue 289423002: DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

Issue 289423002: DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8InjectedScriptHostCustom.cpp ('k') | Source/core/inspector/InjectedScriptCanvasModuleSource.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp b/Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

index f1a88298a545ab8a9a5c21b893673c239263bf36..f72fb698d73af7959c6782e6cb53b0aace17eff9 100644

--- a/Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8JavaScriptCallFrameCustom.cpp

@@ -35,11 +35,11 @@

namespace WebCore {

-void V8JavaScriptCallFrame::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

+void V8JavaScriptCallFrame::evaluateWithExceptionDetailsMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)

{

JavaScriptCallFrame* impl = V8JavaScriptCallFrame::toNative(info.Holder());

String expression = toCoreStringWithUndefinedOrNullCheck(info[0]);

- v8SetReturnValue(info, impl->evaluate(expression));

+ v8SetReturnValue(info, impl->evaluateWithExceptionDetails(expression));

}

void V8JavaScriptCallFrame::restartMethodCustom(const v8::FunctionCallbackInfo<v8::Value>& info)