DevTools: added injectedScript.evaluateWithDetails, that return exception details if it occured

Source/bindings/core/v8/EvaluateExceptionDetailsFactory.cpp

Index: Source/bindings/core/v8/EvaluateExceptionDetailsFactory.cpp
diff --git a/Source/bindings/core/v8/EvaluateExceptionDetailsFactory.cpp b/Source/bindings/core/v8/EvaluateExceptionDetailsFactory.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..5e5b73848364a1a1319ba9871db974ba9f6c0526
--- /dev/null
+++ b/Source/bindings/core/v8/EvaluateExceptionDetailsFactory.cpp
@@ -0,0 +1,25 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "bindings/core/v8/EvaluateExceptionDetailsFactory.h"
+
+#include "bindings/core/v8/V8Binding.h"
+
+#include <v8-debug.h>
+
+namespace WebCore {
+
+v8::Handle<v8::Object> createEvaluateExceptionDetails(v8::Handle<v8::Message> message, v8::Isolate* isolate)

[pfeldman, 2014/07/05 20:11:06]

Converting a v8::Message into v8::Object of an ad-hoc structure does not sounds
like a generally useful thing. Others would be puzzled with this class lying in
bindings. Declare it in other of the call-sites and reuse in another?

+{
+    v8::Handle<v8::Object> exceptionDetails = v8::Object::New(isolate);
+    exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "text"), message->Get());
+    exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "url"), message->GetScriptOrigin().ResourceName());
+    exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "line"), v8::Integer::New(isolate, message->GetLineNumber()));
+    exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "column"), v8::Integer::New(isolate, message->GetStartColumn()));
+    exceptionDetails->Set(v8::String::NewFromUtf8(isolate, "stackTrace"), message->GetStackTrace()->AsArray());
+    return exceptionDetails;
+}
+
+} // namespace WebCore