Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp

Issue 2894103002: Int and Float properties for Accessibility Object Model phase 1 (Closed)
Patch Set: Update webexposed/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp b/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
index 8d701aebe1681b01122f9aeb8dbbd1ada6de9453..73424e35c70c26f89c6a22f908872554ad520548 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp
@@ -104,9 +104,11 @@ bool AXTableCell::IsTableCell() const {
}
unsigned AXTableCell::AriaColumnIndex() const {
- const AtomicString& col_index = GetAttribute(aria_colindexAttr);
- if (col_index.ToInt() >= 1)
- return col_index.ToInt();
+ uint32_t col_index;
+ if (HasAOMPropertyOrARIAAttribute(AOMUIntProperty::kColIndex, col_index) &&
+ col_index >= 1) {
+ return col_index;
+ }
AXObjectImpl* parent = ParentObjectUnignored();
if (!parent || !parent->IsTableRow())
@@ -116,9 +118,11 @@ unsigned AXTableCell::AriaColumnIndex() const {
}
unsigned AXTableCell::AriaRowIndex() const {
- const AtomicString& row_index = GetAttribute(aria_rowindexAttr);
- if (row_index.ToInt() >= 1)
- return row_index.ToInt();
+ uint32_t row_index;
+ if (HasAOMPropertyOrARIAAttribute(AOMUIntProperty::kRowIndex, row_index) &&
+ row_index >= 1) {
+ return row_index;
+ }
AXObjectImpl* parent = ParentObjectUnignored();
if (!parent || !parent->IsTableRow())

Powered by Google App Engine
This is Rietveld 408576698